search

kindredgroup / puppet-forge-server

Private Puppet forge server supports local files and both v1 and v3 API proxies
69 stars 44 forks source link

Problem with "data_provider" = "function" in the metadata.json? #46

Open flaf opened 8 years ago

flaf commented 8 years ago

Hi,

a) I'm using puppet-forge-server version 1.9.0 (commit ab01f3376be081a426798b4333aed0ada920f637) and during a puppet module upgrade mymodule, I have error messages in the syslog (see here).

Is there a problem with puppet-forge-server and the "function" data provider in metadata.json?

b) I don't know if it was related, but I was unable to upgrade my module. A false problem of dependencies was mentioned. But dependencies were fine. I have forced the upgrade of my module and of one dependency which must be upgraded too and after that all was installed correctly without any problem of dependency (puppet module list didn't mention any problem of dependency).

Impossible to reproduce the problem b) however...

i11 commented 8 years ago

Hi,

It would be helpful to look at your metadata.json and a way to reproduce the upgrade issue. The error message regarding data_provider is harmless. It occurs here: https://github.com/unibet/puppet-forge-server/blob/master/lib/puppet_forge_server/models/builder.rb#L26.It's either a new supported or a custom metadata field. https://github.com/unibet/puppet-forge-server/blob/master/lib/puppet_forge_server/models/metadata.rb could be updated to include it.

flaf commented 8 years ago

Sorry, indeed I should give an example of metadata.json. Here is an example that triggers the error here. I think data_provider is a new entry since Puppet 4. It's documented here. Its value can be null, "none", "hiera" or "function".