search

kindredgroup / puppet-forge_server

A Puppet module for managing Puppet Forge Server
Other
5 stars 23 forks source link

Feature: Add Debian / Ubuntu Compatibility #13

Closed hybby closed 7 years ago

hybby commented 7 years ago

Great project. I tried to use your Puppet Module to install this under Ubuntu Trusty (14.04) and came up against a couple of Redhat vs. Debian-isms.

Once I rewrote the init script using the LSB init functions and replaced the defaults file (removing the quotes from paths, which start-stop-daemon's --exec option didn't like), everything "just worked".

Hopefully you can use this as-is and release a new version; I'd be keen to use Puppetfile and the Forge to keep track of this module rather than having to have a local version.

Thanks again for writing this.

hybby commented 7 years ago

Added operatingsystem_support to metadata.json so that I could use mcanevet/rspec-puppet-facts to perform multi-OS testing.

First batch of tests are passing in Travis, but the second and third test suites are failing for an unrelated reason:

 Evaluation Error: Error while evaluating a Function Call, undefined method `repeated_param' for #<Puppet::Functions::DispatcherBuilder:0x000000047a3790> at /home/travis/build/unibet/puppet-forge_server/spec/fixtures/modules/forge_server/manifests/init.pp:98:3 on node testing-docker-6de6c174-3583-4f9e-bd88-ebbbc1a07213.ec2.internal

This seems to be due to the version of stdlib that's being pulled down by librarian-puppet; I suspect there's a breaking change somewhere in a newly released version that's being hit.

hybby commented 7 years ago

I can't reproduce the last tiny issue with the tests on my setup. No idea why bundle exec rake validate is failing on Travis.

Any chance you could take a look, @unibet? Everything else should be good to go.

jlyheden commented 7 years ago

Thanks for the contribution! I will merge this PR despite the build failures seeing it is not related to your code changes and will try to fix the failing test as a separate issue.