Adding autoregister hostname

kindredgroup / puppet-go

Puppet module for managing Thoughtworks Go

Other

8 stars 12 forks source link

Adding autoregister hostname #13

Closed levenaux closed 7 years ago

levenaux commented 7 years ago

Creating multiple agents on the one server will cause all agents to use the same Agent Name. Changed code to use the $name passed to the define type as part of the auto registration.

jlyheden commented 7 years ago

Could we default the value to undef and only configure hostname in the properties file only if explicitly set? A bit reluctant to introduce behaviour change that cannot be opted out of.

levenaux commented 7 years ago

I've now made the changes as requested

jlyheden commented 7 years ago

Looks good, thanks!