fix: removes duplicate base from resolved src

kindspells / astro-shield

Astro integration to enhance your website's security with SubResource Integrity hashes, Content-Security-Policy headers, and other techniques.

https://astro-shield.kindspells.dev

MIT License

57 stars 6 forks source link

fix: removes duplicate base from resolved src #145

Closed ndj91 closed 3 weeks ago

ndj91 commented 1 month ago

Fixes issue #144

dnlek commented 1 month ago

💯

ndj91 commented 1 month ago

Hi @castarco,

How are you? Just wondering if you've had a chance to look at this one?

castarco commented 3 weeks ago

Hi everyone, @ndj91 . I'm sorry I wasn't available for so long, it has been a long time of crushing load work for me. I'll be reviewing issues and PRs this weekend.

castarco commented 3 weeks ago

@ndj91 so far looks good, but the formatting is all off. Please run

pnpm format
git commit --amend
git rebase -i main
git push origin --force-with-lease

Thank you for your effort 🙏🏻 .

castarco commented 3 weeks ago

@ndj91 I created a parallel PR (#158) including your commit with the change requests I mentioned here, your authorship is preserved, but the commit will appear as dual because of the formatting changes I included.

I'll be releasing your changes in a few minutes :) .

ndj91 commented 4 days ago

Thanks for that, was also super busy with work and didn't see.

Appreciate you jumping on and getting this merge in asap