kinduff / csgo_exporter

A Prometheus exporter for Counter-Strike: Global Offensive.
Apache License 2.0
19 stars 3 forks source link

Fix datasource variable usage in the dashboard #29

Closed colega closed 3 years ago

kinduff commented 3 years ago

@colega Thanks a lot for your contribution.

I'm wondering, what's the advantage of having this field declared?

colega commented 3 years ago

Oh, sorry, the commit message wasn't added as PR description 🤦

It was:

Some "dashboard" fields were set to null, which broke the queries on the import.

This field is present in most of the panes, which work properly, but where it's set to null, Grafana sets the datasource to the example Grafana datasource when dashboard is imported, and the Prometheus query is lost forever.

Setting "dashboard" to the one selected during the import makes everything work just fine.

kinduff commented 3 years ago

Perfect, thanks a lot for your contribution. Merging this.

kinduff commented 3 years ago

@all-contributors please add @colega for content

allcontributors[bot] commented 3 years ago

@kinduff

I've put up a pull request to add @colega! :tada: