kinduff / csgo_exporter

A Prometheus exporter for Counter-Strike: Global Offensive.
Apache License 2.0
19 stars 3 forks source link

[dashboard] Last match CT/T Wins is not what one would expect #30

Closed colega closed 3 years ago

colega commented 3 years ago

I'd expect CT Wins and T wins to be the amount of rounds that I won being CT or T in that match, but instead, that's just the match itself stats, which is pretty useless here IMO.

See:

image

While that match was https://csgostats.gg/match/38232470

image

I think it's more useful to render the csgo_last_match_metric{type="wins"} as wins and csgo_last_match_metric{type="wins"} - csgo_last_match_metric{type="rounds"} as losses there. WDYT?

kinduff commented 3 years ago

@colega I'm pretty bummed about this, Valve considers the warm up matches as rounds, and they include them all in the metric. I currently have no way to know which are rounds from the game, and rounds from the warm up matches.

valveplsfix

The alternative would be to actually parse the demos, but that's a lot of work, but it's worth imho.

kinduff commented 3 years ago

I think it's more useful to render the csgo_last_match_metric{type="wins"} as wins and csgo_last_match_metric{type="wins"} - csgo_last_match_metric{type="rounds"} as losses there. WDYT?

Missed this part of the message. Can't read today apparently.

I like the idea, want to do a test and post a screenshot?

colega commented 3 years ago

I made a proposal in https://github.com/kinduff/csgo_exporter/pull/33 PTAL.