search

kinduff / csgo_exporter

A Prometheus exporter for Counter-Strike: Global Offensive.
Apache License 2.0
19 stars 3 forks source link

Label metrics with `player_name` too #31

Closed colega closed 3 years ago

colega commented 3 years ago

If there were multiple exporters running, the player ID isn't very human friendly. Since we have it, we could add a player_name label too.

A next step would be to have that player_name as template variable in the dashboard, so one could set up a Grafana for his entire team/clan/etc.

kinduff commented 3 years ago

@colega Thanks for reporting. This is actually a bug, we used to override the player variable if the STEAM_NAME was provided. I will add both, but I need to consider the advantages since I need to do a reverse lookup to convert from SteamID to SteamName.

colega commented 3 years ago

I think both can be useful, and since this doesn't add cardinality I'd try to export both labels.