search

kine / NVRAppDevOps

Navertica DevOps scripts for managing Microsoft Dynamics 365 Business Central Apps
31 stars 29 forks source link

Add $additionalParameters #9

Closed MJECloud closed 5 years ago

MJECloud commented 5 years ago

Allow to use own additionalParameters See here: https://github.com/kine/MSDyn365BC_AppTemplate/pull/5

kine commented 5 years ago

Thanks, but I will preffer way, where the additional parameters in the functions are dynamically created from custom additional parameters and the one already used. This will allow to define only new custom parameters in the settings.ps1. Or do you need to have way to overload even these? I mean mainly the --volume ""$($RepoPath):C:\app" which is critical for other functions to be there. Rest could be optional and e.g. used as "default" if not defined from outside.

MJECloud commented 5 years ago

You're right it would be better adding optional parameters to the mandatory. I'll change that.

MJECloud commented 5 years ago

Now you can specifiy optionalParameters array. This will added to the additionalParameters array

kine commented 5 years ago

Get-ALAppOrder is missing line [CMDLetBinding(DefaultParameterSetName="Path")] Is it mistake or it should not be there? This was fixed by some previous PR...

MJECloud commented 5 years ago

Thank you, it was a mistake. I fixed it.

kine commented 5 years ago

Thanks! Merged. Will be included in next version.