search

kinetic-fit / fit-android-issues

Public Issue Tracker for the Android Kinetic Fit Mobile Application
2 stars 2 forks source link

Workout sequence not correct and timing wrong on logged data #16

Closed RoyalPeddler closed 4 years ago

RoyalPeddler commented 4 years ago

Describe the bug I noticed while using one of the inbuilt workouts (On the Rivet) that the target power level / recovery sequencing was incorrect towards the end of the workout. When the main workout finished and moves to the 10 x minute cooldown period at the end, the intervals and power targets continued to alternate at 60 second intervals, instead of a single10 min cooldown interval /power target.

Also when I exported the data to CSV I could see that it registered the 10 minute warmup prior to the main workout at 1200sec instead of 600sec.

Not a big issue but these did not happen when using the main android app.

To Reproduce Steps to reproduce the behavior: 1.Carry out 'On the Rivet' in built workout.

  1. Export the workout to csv at the end.

Expected behavior Warm down period to be 1 x single 10 minute interval, instead of 10 x 1 minute intervals

Screenshots Not applicable

Smartphone (please complete the following information):

Trainer (please complete the following information):

lexicalninja commented 4 years ago

Thanks for the report.

I will look into the warmup time issue.

I will need to look at the interval problem and see what it is coded at in the database. It may have been a migration issue. I will get back to you once I have a chance to try and reproduce the issue

lexicalninja commented 4 years ago

I believe 229 may have fixed the issue. I am working on 230 build this morning and it is definitely fixed in this build. I am running the On the Rivet workout right now to try and figure out what is happening with the intervals there and will hopefully have a fix soon.

Please let me know if the CSV issue is fixed over the weekend

RoyalPeddler commented 4 years ago

OK thanks for the update. I'll see I can try it out over the weekend.

Best regards

Ian

On Fri, 28 Feb 2020, 16:20 lexicalninja, notifications@github.com wrote:

I believe 229 may have fixed the issue. I am working on 230 build this morning and it is definitely fixed in this build. I am running the On the Rivet workout right now to try and figure out what is happening with the intervals there and will hopefully have a fix soon.

Please let me know if the CSV issue is fixed over the weekend

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/kinetic-fit/fit-android-issues/issues/16?email_source=notifications&email_token=AOU2ZHLGOSFGXLA6RPAKL53RFE2V7A5CNFSM4K3BDW52YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENJCPXI#issuecomment-592586717, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOU2ZHLFCUU3ITS6LLATWWTRFE2V7ANCNFSM4K3BDW5Q .

RoyalPeddler commented 4 years ago

Hi I did a session last night and can confirm that the warmup duration was recorded correctly at 600sec when exported to CSV.

Thanks

Ian

On Fri, Feb 28, 2020 at 4:20 PM lexicalninja notifications@github.com wrote:

I believe 229 may have fixed the issue. I am working on 230 build this morning and it is definitely fixed in this build. I am running the On the Rivet workout right now to try and figure out what is happening with the intervals there and will hopefully have a fix soon.

Please let me know if the CSV issue is fixed over the weekend

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/kinetic-fit/fit-android-issues/issues/16?email_source=notifications&email_token=AOU2ZHLGOSFGXLA6RPAKL53RFE2V7A5CNFSM4K3BDW52YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENJCPXI#issuecomment-592586717, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOU2ZHLFCUU3ITS6LLATWWTRFE2V7ANCNFSM4K3BDW5Q .

lexicalninja commented 4 years ago

thanks. I will mark this as a bug and try and figure out the last intervals issue.

jacco411 commented 4 years ago

I'm on 2.4.1 (230). I am also having similar issues with not getting into the cool down part of a workout. I did one on Wednesday - Criss Cross Super threshold 2x10. It skipped the "rest" interval between the 10 minute Threshold work and also never went into the cool down. I've been having this problem for several weeks now.

Lucylea commented 4 years ago

I have tried Kinetic Fitness test 42, and Criss cross threshold 112 workout tonight, which turns out that the planned power graph at the bottom GUI doesn't match the target power and cadence in the cool down process. for example. in the Kinetic Fitness test 42 workout, in the last 10 minutes, the power graph is a smooth cooling down process, whereas in the target value, there are 4 minutes cooling down + 2 minutes intervals + 4 minutes cooling down. And in Criss cross threshold 112 workout, it is complicated to describe the last 10 minutes of actual value of taget power and cadence.

lexicalninja commented 4 years ago

@Lucylea thank you for trying all those. I am working on figuring this issue out right now and this is extremely helpful. I will be working on this today to try and get it fixed. It seems that the interval data is correct, but the calculations that set the target power are not using the correct interval as the graph. I will let you know how things go later today.

Thanks again.

lexicalninja commented 4 years ago

@RoyalPeddler @jacco411 @Lucylea I have worked on this issue today and believe it to be solved. Please download version 2.5.4 (235) when it becomes available and let me know. It should also fix the dat displayed in the popups before an interval starts to give you the correct power values.

Please let me know if you are still experiencing this and what workout you are running. Thanks

Lucylea commented 4 years ago

Thank you, I updated the app, but kinetic fit 2.5.4 is not available in the play store, so I updated the app to 2.5.3 version. I tried Criss cross threshold 2 plus 10 workout, the sequence and timing work well until the first cooling down come, that is at 12 minutes. it should be cooling phase, but the power target repeat the previous 4 minutes power (85% FTP and 100% FTP) twice (8 mintues). but the cooling phase time < 8 mintues, so it affects the following workout. so the sequence and timing does not match the the power graph at the bottom of GUI.

lexicalninja commented 4 years ago

It was not changed until version 2.5.4, so you will need to check for that version to make it to the store for you. It was basically grabbing the intervals for the first two hills and valleys and using those instead of the cool down, so that is what you see in the all of the interval workouts.

Once 2.5.4 gets to you and you do your regular workout, it should be fixed for you. It may take a little more time than usual right now. Thanks

Lucylea commented 4 years ago

Yes, I tried the previous bug workouts, it turns out this bug has been fixed. Thank you for doing this. 

---Original--- From: "lexicalninja"<notifications@github.com> Date: 2020/4/3 23:31:48 To: "kinetic-fit/fit-android-issues"<fit-android-issues@noreply.github.com>; Cc: "Lucylea"<497717576@qq.com>;"Mention"<mention@noreply.github.com>; Subject: Re: [kinetic-fit/fit-android-issues] Workout sequence not correct and timing wrong on logged data (#16)

It was not changed until version 2.5.4, so you will need to check for that version to make it to the store for you. It was basically grabbing the intervals for the first two hills and valleys and using those instead of the cool down, so that is what you see in the all of the interval workouts.

Once 2.5.4 gets to you and you do your regular workout, it should be fixed for you. It may take a little more time than usual right now. Thanks

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

lexicalninja commented 4 years ago

Excellent. Thank you for your help in fixing this.

RoyalPeddler commented 4 years ago

Hi

I'm not sure if this is a separate issue but I've noticed that teh workouts showing up on my app are not ones I have ridden, there are multiple ones for each day making me thing that maybe all Beta users workouts are being uploaded to my account somehow?

Thanks

Ian

On Sat, Apr 4, 2020 at 5:02 PM lexicalninja notifications@github.com wrote:

Excellent. Thank you for your help in fixing this.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/kinetic-fit/fit-android-issues/issues/16#issuecomment-609049962, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOU2ZHJQ2OVWNHABEIWITNLRK5KYJANCNFSM4K3BDW5Q .

lexicalninja commented 4 years ago

This is a separate issue that came up in #32. the new version should force a log out/ log in if it sees this, but logging out will fix this. Details are in the closed issue linked.

Please be sure to make each bug you find a separate issue and do a quick search on the issues page to see if it is already opened. That way we can have a single thread for each bug to make sure we don't talk at cross purposes.

Thanks for reporting your issues, it helps make Fit better for everyone. I greatly appreciate it

RoyalPeddler commented 4 years ago

Ok thanks for getting back to me. Sorry I should have checked out the issue page first, ill do that next time.

Thanks

On Thu, Apr 23, 2020 at 3:13 PM lexicalninja notifications@github.com wrote:

This is a separate issue that came up in #32 https://github.com/kinetic-fit/fit-android-issues/issues/32. the new version should force a log out/ log in if it sees this, but logging out will fix this. Details are in the closed issue linked.

Please be sure to make each bug you find a separate issue and do a quick search on the issues page to see if it is already opened. That way we can have a single thread for each bug to make sure we don't talk at cross purposes.

Thanks for reporting your issues, it helps make Fit better for everyone. I greatly appreciate it

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/kinetic-fit/fit-android-issues/issues/16#issuecomment-618418352, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOU2ZHJUUZX5QV4GFWVVSZLROBEINANCNFSM4K3BDW5Q .

lexicalninja commented 4 years ago

No worries. We are all working together and learning here 😄