Modify DB Model - Githubissues

king-michael / simulation_database

Apache License 2.0

1 stars 1 forks source link

Modify DB Model #25

Closed andrejberg closed 5 years ago

andrejberg commented 5 years ago

Add priority attribute to each DB Table to store information about source of information

(please edit)

Source	priority
unknown / default	0
parsed from file	1
parsed from simDB generated file (XML)	2
added/modified by user	3

It would be nice if we could add a variable amount of additional information to a Group. Comparable to Keyword for entries.

andrejberg commented 5 years ago

Add status attribute to Main table. Can be used for

active (default status for entry)
deleted (entries which will be not displayed but can be restored)
archived

two attributes deleted and archived which are of type bool. should be more effective when checking for this attributes than string comparison but is less flexible than first option.

king-michael commented 5 years ago

Do we need the status attribute? Can't we add a keyword for status = deleted= orarchived` instead? Since the majority is active anyway?

king-michael commented 5 years ago

I think we have two options for the GroupKeywords.:

add a new table GroupKeywords for the keywords
extend the table Keywords by a column table, so we store everything in the same and go with .join(Main).filter(_and(Main.id == Keywords.main_id , Keywords.table == 'main') to get keywords for the main table, and table = 'group's for groups

andrejberg commented 5 years ago

Group Keywords: I would guess that making an extra table will be the better solution. Makes life easier

Status: Hm, why we should do this? (adding Keyword status) So that we have to add exceptions in all Keywords functions (so that the status keyword is not returned) and also return an error message if someone tries to add a keyword status=very_important?