search

king6cong / react-native-ijkplayer

React Native Component for ijkplayer
74 stars 28 forks source link

Remove Android activity params for new react-native link #3

Closed tengattack closed 7 years ago

tengattack commented 7 years ago

Currently, registering a module provided in the getPackages method of the MainApplication.java file, which we can't get the activity instance. On the other hand, we don't need to know the activity instance in this module.

Reference: register-the-module

king6cong commented 7 years ago

@tengattack thanks for the PR.

Sorry about not updating the repo for quite a long time. I have just pushed some changes that had been done but not pushed. This should include some adjustments needed for higher versions of RN. Please help me check this.

tengattack commented 7 years ago

Great! Thanks

tengattack commented 7 years ago

https://github.com/king6cong/react-native-ijkplayer/commit/2d5f338677fdc651d818cb2b4f17dbac5afd236d#diff-d7d8b44359f3774ccea2e15dce0025d9R43

By the way, I think there is no necessary to get the MainActivity.

king6cong commented 7 years ago

Yeah, Do you have interest in help maintaining this repo? Collaborator invitation has been send :) I think a good media player is essential for the RN ecosystem, but I have been away from RN for a while and can't focus on this. Your help is appreciated 😄

tengattack commented 7 years ago

Sure! By the way, how can i publish new version to npm? My npm account is tengattack.

king6cong commented 7 years ago

Cheers, you have been added as collaborator on npm