search

king8fisher / aoe2card

https://aoe2card.vercel.app
MIT License
3 stars 0 forks source link

Return back purely functional components #48

Open king8fisher opened 1 year ago

king8fisher commented 1 year ago

During #46 a lot of purely functional components have been turned into regular components as part of attempt to deal with the re-render slowness. Now they can be converted back as slowness belonged to huge amount of <SlTooltip> components now rendered conditionally.

king8fisher commented 1 year ago

@cnohall I'm hoping you take on this. I made components very hard to read while tweaking speed (which appeared to be irrelevant).

cnohall commented 1 year ago

It'll be quite a big thing to tackle. Will probably have to spread it over several PRs.

My suggestion is to eventually move away from components such as <SlTooltip> to have more control over UI and performance.

king8fisher commented 1 year ago

@cnohall No worries, it can wait. Maybe we should focus on the missing data presentation first, I mean #51.