search

kingToolbox / WindTerm

A professional cross-platform SSH/Sftp/Shell/Telnet/Serial terminal.
https://kingtoolbox.github.io
23.94k stars 1.83k forks source link

I have created a theme, how can I share it? #62

Open lpadula opened 3 years ago

lpadula commented 3 years ago

I have created a dracula theme for this awesome terminal:

dracula.zip

Is there a way to push it into the repo?

kingToolbox commented 3 years ago

Wow, it is so amazing. You are the first contributor to WindTerm, thank you very very much!

I will build and provide ways to share, such as a themes folder and "Pull requests". In addition, would you like to authorize me to distribute your theme and WindTerm together? And put your name on the list of contributors?

In addition, there are two small problems. One is background-color of #TextPreview. You need to set transparency of the color to ensure the preview content visible, and it is also better to set a color different from the view background color, so that the preview content can be distinguished well. In addition, It would be better if the scroll bar is always visible, and unlike MacOS, there is no auto-hide scrollbar in Windows (Windows 10 provides while that feature is limited to (mostly) Windows Store applications and not desktop apps), so the scroll bar cannot be found quickly after hiding.

I will provide more detailed documentation and interface in subsequent versions as soon as possible to better provide assistance and convenience for customization of themes, keyboards, etc. Thank you again!

Shellfishgene commented 3 years ago

Text selections are invisible in this theme...

kingToolbox commented 3 years ago

I think this may be that the color of the selection is not set correctly, you can open the configuration file themes/dracula/scheme.theme and modify: 

{
    "name": "text.selection",
    "style": {
        "foreground": "#282A36",
        "background": "#282A36",
        "decorationStyle": "roundBox"
    }
},

to:

{
    "name": "text.selection",
    "style": {
        "foreground": "#805050FF",
        "background": "#805050FF",
        "decorationStyle": "roundBox"
    }
},

The color #805050FF here is just a demonstration, and the foreground and background colors can also take different color values. You can set them to any colors you like, but it is best to both set the alpha channel.

lpadula commented 3 years ago

New version here: dracula.zip

Shellfishgene commented 3 years ago

Thanks, works!

lpadula commented 3 years ago

Hi, I forgot to share this: https://github.com/lpadula/windterm-dracula

kingToolbox commented 3 years ago

@lpadula I am planning to add two folders themes and translations to the repository to facilitate the community to share the new themes and translations. I expect it should be available this month. I hope I have the honor to have your awesome dracula theme as the first theme. Thank you very much for your continued support.

lpadula commented 3 years ago

Maybe i could help with the spanish translation too!

kingToolbox commented 3 years ago

When I add the folders, I will update the progress here, please stay tuned, thank you. :smile: