search

kingctan / oppia-origin

Automatically exported from code.google.com/p/oppia
Apache License 2.0
0 stars 0 forks source link

Code review request #825

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Branch name:
fix-ff-overwrite

Link to the relevant commit(s):
https://code.google.com/p/oppia/source/detail?r=fe0873cb256f7cc0890df879e930a592
8ad73f85&name=fix-ff-overwrite#

Purpose of code changes on this branch:
Overwriting of widgets in FF after editing

When reviewing my code changes, please focus on: bugs

After the review, I'll merge this branch into: develop

Note: There is a minor change in behavior as a result of this fix. Before, 
cursor position would be restored to wherever the cursor was before clicking 
the widget. Now, cursor position will always be restored to immediately after 
the widget being clicked. I think this is acceptable given the bugfix, but I'd 
welcome any input on the pros/cons of this change.

Note 2: This does not fix the bugs which will occur if you try clicking on a 
widget when it is the only element in the editor.

Original issue reported on code.google.com by AYZh...@gmail.com on 17 Jun 2015 at 8:48

GoogleCodeExporter commented 9 years ago 
Thanks, Allan! Looks very nice.

Re note 1, I think the current behaviour (after your fix) is good.

Original comment by s...@seanlip.org on 18 Jun 2015 at 1:46