search

kingerpku / maven-replacer-plugin

Automatically exported from code.google.com/p/maven-replacer-plugin
MIT License
0 stars 0 forks source link

Support project.build.sourceEncoding #68

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
By looking at issue #61 and the usage guide, I assume that the plugin uses the 
system default encoding per default.

I guess it would be good to use the property project.build.sourceEncoding - if 
present - instead, as other plugins do.

See 
http://docs.codehaus.org/display/MAVENUSER/POM+Element+for+Source+File+Encoding

Original issue reported on code.google.com by cku...@gmail.com on 8 Jun 2012 at 2:30

GoogleCodeExporter commented 8 years ago 
You can set <encoding>${project.build.sourceEncoding}</encoding> in your 
configuration to do this. Would this suffice?

Original comment by baker.st...@gmail.com on 9 Jun 2012 at 7:58

GoogleCodeExporter commented 8 years ago 
Yes, I can do this currently, but no it won't suffice IMO.
The point of this issue is, that the replacer plugin should use 
${project.build.sourceEncoding} as default encoding - as most other plugins do, 
too.

Original comment by cku...@gmail.com on 9 Jun 2012 at 9:23

GoogleCodeExporter commented 8 years ago 
Okay, I will look into doing this for the next release. I don't think it's a 
priority though since there is a work around.

Original comment by baker.st...@gmail.com on 17 Jun 2012 at 11:01

GoogleCodeExporter commented 8 years ago 
Thanks, this will be in the next release.

Original comment by baker.st...@gmail.com on 14 Sep 2012 at 6:46

GoogleCodeExporter commented 8 years ago 
[deleted comment]
GoogleCodeExporter commented 8 years ago 
[deleted comment]
GoogleCodeExporter commented 8 years ago 
Thanks for fixing this!

Original comment by cku...@gmail.com on 17 Sep 2012 at 9:28

GoogleCodeExporter commented 8 years ago 
Released.

Original comment by baker.st...@gmail.com on 18 Sep 2012 at 12:25