kinggath / Workshop-Plus

Treats workshop mode like photoshop. Giving you undo buttons, layers, and more tools!
18 stars 4 forks source link

Non-traditional Scrap Methods Bypass RemoveItemFromLayer #15

Open kinggath opened 6 years ago

kinggath commented 6 years ago

Things like the Town Meeting Gavel, or even calling the scrapobject thread from WorkshopFramework are not going to end up triggering RemoveItemFromLayer, even though those items might be on a layer. This will likely cause problems.

Potential problems:

  1. Broken link in the linkedrefchain, making working with the layer difficult.
  2. Persistent refs. This is the real worry, that the items will be perpetually stuck in limbo.

Solutions:

  1. Setup scrapobject thread to check for layer linking via WS+ detection and if found call RemoveItemFromLayer. Once we eventually tie SS into WSFW more, we can switch to using that thread.