kinghat / tabbed-card

a custom card for home assistant that utilizes tabs to segregate individual cards.
MIT License
87 stars 10 forks source link

Labels blank #17

Closed baj24 closed 1 year ago

baj24 commented 1 year ago

When I updated to v0.3.0 ,the labels are blank. When I downgraded to v0.2.0, they are fine.

kinghat commented 1 year ago

When I updated to v0.3.0 ,the labels are blank. When I downgraded to v0.2.0, they are fine.

can you please post your full config and a screenshot of it?

samuelmcconnell commented 1 year ago

I'm having the same trouble. This is with the theme waves, both light and dark.

v0.2.0: image

v0.3.0: image

Card config:

type: custom:tabbed-card
options: {}
tabs:
  - label: Sun
    card:
      type: entity
      entity: sun.sun
  - label: 3D Printer
    card:
      type: entity
      entity: person.redacted
kinghat commented 1 year ago

I'm having the same trouble. This is with the theme waves, both light and dark.

v0.2.0: image

v0.3.0: image

Card config:

type: custom:tabbed-card
options: {}
tabs:
  - label: Sun
    card:
      type: entity
      entity: sun.sun
  - label: 3D Printer
    card:
      type: entity
      entity: person.redacted

ya, sorry, growing pains :sweat_smile: it was a breaking upgrade as the schema changed. the schema in the readme is the correct way moving forward: https://github.com/kinghat/tabbed-card#card-schema

tabs:
  - card:
      type:
    styles?:
    attributes?:
      label?: string

please reply with confirmation if this fixed your issue so i can close.

samuelmcconnell commented 1 year ago

Confirmed, moving the label key under attributes made them reappear. Thanks!

kinghat commented 1 year ago

Confirmed, moving the label key under attributes made them reappear. Thanks!

sorry about the breakage and thanks for taking the time to post your config and screenshot :pray:

@baj24 if this doesnt fix your issue i will reopen.

renarena commented 1 year ago

Its still wrong in the default yaml after adding a new card.

type: custom:tabbed-card
options: {}
tabs:
  - label: Sun
    card:
      type: entity
      entity: sun.sun
kinghat commented 1 year ago

Its still wrong in the default yaml after adding a new card.

type: custom:tabbed-card
options: {}
tabs:
  - label: Sun
    card:
      type: entity
      entity: sun.sun

good catch! https://github.com/kinghat/tabbed-card/blob/beac5c080e11b8674021d3642cde57b325c678ea/src/tabbed-card.ts#L72 this is going to be fixed in the next release!