search

kinghat / tabbed-card

a custom card for home assistant that utilizes tabs to segregate individual cards.
MIT License
87 stars 10 forks source link

README.md cleanup #20

Closed samuelmcconnell closed 1 year ago

samuelmcconnell commented 1 year ago

Removed a lot of stray question marks in schema YAML, typo fixes

samuelmcconnell commented 1 year ago

This is my first PR, please let me know if this is not the correct way to do it!

kinghat commented 1 year ago

Removed a lot of stray question marks in schema YAML, typo fixes

those are not stray, they are notations to convey that the property is optional. the card will function without those properties.

This is my first PR, please let me know if this is not the correct way to do it!

thanks for taking interest in the project and opensource. i would say proper "PR etiquette" to follow is to open an issue and ask the maintainer(s) if they are accepting PRs in the first place and also what you are wanting to contribute. this benefits are twofold, you dont needlessly spend time on something that wont be accepted and the maintainer(s) dont feel bad for turning down something that someone put effort into.

in this case im going to close the PR as the documentation, in this regard, is correct.