search

kinghat / tabbed-card

a custom card for home assistant that utilizes tabs to segregate individual cards.
MIT License
87 stars 10 forks source link

Tab icon height should be a bit higher #77

Open dieugab opened 1 year ago

dieugab commented 1 year ago

Hi! First of all, great component! I've only got a minor nitpick with the icon height. I believe it should be more center alligned with the text label. In the below example I've added a bottom margin of 8px: image

Compared to the default: image

I'd make a Pull request if I knew how to code, but sadly I do not.

kinghat commented 1 year ago

this was mentioned here: https://github.com/kinghat/tabbed-card/discussions/38#discussion-4564290 and i asked them to open an issue about it here: https://github.com/kinghat/tabbed-card/discussions/38#discussioncomment-4131949. they mentioned that it was functioning properly in the mobile app. is this the case for you or is it still an issue there as well? in either scenario, can you reply what mobile device you checked on? thanks for the report :pray:

dieugab commented 1 year ago

@kinghat Screenshots I posted in the OP were from a Windows PC, through Microsoft Edge browser. Just tried on mobile and it looks the same (iPhone running iOS 16.2, through the Home Assistant mobile app/Safari) image

kinghat commented 1 year ago

@kinghat Screenshots I posted in the OP were from a Windows PC, through Microsoft Edge browser. Just tried on mobile and it looks the same (iPhone running iOS 16.2, through the Home Assistant mobile app/Safari)

thanks for you time. it should be fixed in the next alpha if you'd like to test it there.