search

kingmaj0r / KingsBetterAnimations

Uses KosmX's Player Animation mod and GeckoLib to add in better animations
MIT License
0 stars 1 forks source link

Update BetterAnimations.java #4

Closed EchoEllet closed 7 months ago

EchoEllet commented 7 months ago

This remove unnecessary implements, I'm not 100% sure about it though, ModInitializer should be for both server and client, correct me if I'm wrong

EchoEllet commented 7 months ago

We also need to update this file

kingmaj0r commented 7 months ago

Im not sure about that currently, will have to look into it. Concering the update for fabric.mod.json, feel free to update it as needed

EchoEllet commented 7 months ago

Im not sure about that currently, will have to look into it. Concering the update for fabric.mod.json, feel free to update it as needed

There are DedicatedServerModInitlizer and ClientInitlizer, ModInitlizer is for both

kingmaj0r commented 7 months ago

looking into this, it seems your correct indeed.

kingmaj0r commented 7 months ago

but its recommended to use onInitialize for code that is common to both environments.

EchoEllet commented 7 months ago

We also need to update this file

Don't forget to update this file, my internet connection doesn't allow me to clone the repo, In updating using GitHub web

kingmaj0r commented 7 months ago

what needs updating in the fabric.mod.json? sorry im still new to coding mods in minecraft.

EchoEllet commented 7 months ago

what needs updating in the fabric.mod.json? sorry im still new to coding mods in minecraft.

New and you seems to grow in Mc modding too fast

In the entrypoints, we will use the main instead of client and server arrays

kingmaj0r commented 7 months ago

Do you think we should create a custom player model so we can make our animations more realistic? so an example would be each arm would have 2 parts and the leg would have 2 parts too. so we could make more interesting animations kind of like mo bends https://www.curseforge.com/minecraft/mc-mods/mo-bends

EchoEllet commented 7 months ago

Do you think we should create a custom player model so we can make our animations more realistic? so an example would be each arm would have 2 parts and the leg would have 2 parts too. so we could make more interesting animations kind of like mo bends https://www.curseforge.com/minecraft/mc-mods/mo-bends

I'm new to mc modding, but in general, I like the current implementation

Only what it is missing is the sword attack in the first person

It will give a much better user experience if we could provide it

I can help you with that, but I don't plan on disappointing you because, like I said, I'm not familiar with mc and fabric api

kingmaj0r commented 7 months ago

Dont worry im new to it too, and sure i'll get the sword attack fixed in first person soon and how about we do the same feature but we make it so it could be disabled and can go back to the normal animations or semi-realistic animations? I personally think it would give the user better experince with more realistic animations but will have to look into it in the future, for now i'll work on getting that sword animation working. Thanks for all the push requests.

kingmaj0r commented 7 months ago

Hey @ellet0, i was looking into the mod and even testing it on my client witch was tested on Quilt 23.0 with minecraft 1.20.1 and i see the sword animation with no issues, could you please send me a gif or a video (not on youtube as my internet is restricted) showing me that it does not work.

mods i've used: KingsBetterAnimations V1.2-BETA 1.20 - 1.20.4 FirstPersonModel 2.3.2 1.20.1

i've made a little video showing that the sword animation seems to work fine:

Screencast from 2024-02-03 12-20-48.webm

EchoEllet commented 7 months ago

Hey @ellet0, i was looking into the mod and even testing it on my client witch was tested on Quilt 23.0 with minecraft 1.20.1 and i see the sword animation with no issues, could you please send me a gif or a video (not on youtube as my internet is restricted) showing me that it does not work.

mods i've used: KingsBetterAnimations V1.2-BETA 1.20 - 1.20.4 FirstPersonModel 2.3.2 1.20.1

i've made a little video showing that the sword animation seems to work fine:

Screencast from 2024-02-03 12-20-48.webm

Yes, by first person, I meant without a third person model. By that, I mean without a first-person model mod

EchoEllet commented 7 months ago

To see what I mean, take a look at Better Combat

EchoEllet commented 7 months ago

Take a look at this

To try it out on 1.20.4

kingmaj0r commented 7 months ago

Hey Ellet, very interesting indeed, i think i got a great idea, how about we try to merge KingsBetterAnimations with bettercombat allowing us to make compatibility easier and fixing the bug you have mentioned, because i think it would be possible to merge it into one mod and easier for us as you would be required to download one mod.

EchoEllet commented 7 months ago

Hey Ellet, very interesting indeed, i think i got a great idea, how about we try to merge KingsBetterAnimations with bettercombat allowing us to make compatibility easier and fixing the bug you have mentioned, because i think it would be possible to merge it into one mod and easier for us as you would be required to download one mod.

That's is great, I have builded the jar file for 1.20.4

I did some workarounds

Let me know if you need me to send the jar to you

EchoEllet commented 7 months ago

This file could use docs comments

kingmaj0r commented 7 months ago

Hey Ellet, very interesting indeed, i think i got a great idea, how about we try to merge KingsBetterAnimations with bettercombat allowing us to make compatibility easier and fixing the bug you have mentioned, because i think it would be possible to merge it into one mod and easier for us as you would be required to download one mod.

That's is great, I have builded the jar file for 1.20.4

I did some workarounds

Let me know if you need me to send the jar to you

Hey ellet, no need, i will compile the jar myself and look into merging it into one but this could take a little while as merging to mods could be a be complex/complicated. I will update you with the progress as soon as i can.