kingslay / KSPlayer

A video player for iOS、macOS、tvOS、visionOS , based on AVPlayer and FFmpeg, support the horizontal, vertical screen. support adjust volume, brightness and seek by slide, support subtitles.
GNU General Public License v3.0
868 stars 182 forks source link

Invalid bundle identifier when pushing to testflight using KSPlayer via SPM (doesnt happen over ccoapods) #781

Closed bgoncal closed 1 month ago

bgoncal commented 1 month ago

Describe the bug A clear and concise description of what the bug is.

"This bundle is invalid. The bundle at path /Frameworks/libshaderc_combined.framework has an invalid CFBundleIdentifier 'com.kintan.ksplayer.libshaderc_combined' There are invalid characters(characters that are not dots, hyphen and alphanumerics) that have been replaced with their code point 'com.kintan.ksplayer.libshaderc\u005fcombined' CFBundleIdentifier must be present, must contain only alphanumerics, dots, hyphens and must not end with a dot. [see the Core Foundation Keys at https://developer.apple.com/library/content/documentation/General/Reference/InfoPlistKeyReference/Articles/CoreFoundationKeys.html#//apple_ref/doc/uid/TP40009249-102070-TPXREF105]"

To Reproduce Steps to reproduce the behavior:

  1. Use KSPlayer through SPM
  2. Archive App
  3. Upload App

Expected behavior App is uploaded successfully

Screenshots If applicable, add screenshots to help explain your problem.

Platform (please complete the following information):

Additional context Add any other context about the problem here. or Using FFmpeg to extract problematic video segments and upload them to GitHub.(ffmpeg -i http://xxx.com/123.mkv -map 0 -c copy -ss 00:00:50 -to 00:04:10 1.mkv)

kingslay commented 1 month ago

这个问题在lgpl分支解决了。

bgoncal commented 1 month ago

Thanks, another workaround was to put the SPM inside a framework and then importing this framework into the main target