Refactor enums, freeathome, pairing

kingsleyadam / local-abbfreeathome

A Python Package for interacting with the ABB (Busch Jaeger) Free@Home System via the Local API

MIT License

3 stars 2 forks source link

Refactor enums, freeathome, pairing #36

Closed kingsleyadam closed 4 days ago

kingsleyadam commented 5 days ago

This PR refactors the ENUM's to remove the id naming convention.

FunctionID --> Function
ParingID --> Pairing

ID becomes a bit confusing as it's not an ID, it's an ENUM and the value is an ID.

I've also changed the FreeAtHome object to expose self._api as a public attribute self.api in case we would need to use the api externally (e.g. Home Assistant using the FreeAtHome class to fetch a value from the API). I don't have a use case yet but it's possible.

github-actions[bot] commented 5 days ago

Package	Line Rate	Health
.opt.hostedtoolcache.Python.3.12.7.x64.lib.python3.12.site-packages.abbfreeathome	100%	✔
.opt.hostedtoolcache.Python.3.12.7.x64.lib.python3.12.site-packages.abbfreeathome.bin	100%	✔
.opt.hostedtoolcache.Python.3.12.7.x64.lib.python3.12.site-packages.abbfreeathome.devices	100%	✔
Summary	100% (1065 / 1065)	✔

github-actions[bot] commented 5 days ago

	Tests	Passed ✅	Skipped ⏭️	Failed ❌
JUnit Test Report	61 ran	61 passed	0 skipped	0 failed

	Test	Result
-	No test annotations available	-