search

kingsleyadam / local-abbfreeathome

A Python Package for interacting with the ABB (Busch Jaeger) Free@Home System via the Local API
MIT License
3 stars 2 forks source link

Implement WindowDoorSensor #52

Closed derjoerg closed 20 hours ago

derjoerg commented 21 hours ago

This implements the Window Door Sensor

derjoerg commented 21 hours ago

I don't know how to fix the test-problem here. This device has only one pairing and this affects the state. If I remove the "not covered" Return False, I get a problem with ruff, if I leave it in I get a problem with the test 😢

kingsleyadam commented 21 hours ago

I don't know how to fix the test-problem here. This device has only one pairing and this affects the state. If I remove the "not covered" Return False, I get a problem with ruff, if I leave it in I get a problem with the test 😢

You can also just add a dummy output (AL_INVALID?)

kingsleyadam commented 20 hours ago

Let me know if you need to me to cut a release, I'll hold off until we're ready to implement into Home Assistant.

derjoerg commented 20 hours ago

Let me know if you need to me to cut a release, I'll hold off until we're ready to implement into Home Assistant.

Will do. I have some more - low hanging fruits - device classes I want to implement

before I dive into to HA development 😃

Later on I will also contribute:

But they look a bit more complex