search

kingsmen732 / Zapfolio

Minimal Portfolio - An opensource portfolio website for easy deployment on Vercel. Customize your profile using the profileConfig file to update links and upload resumes effortlessly. Fork, deploy, and showcase your work with minimal setup!
https://kingsmen732.vercel.app/
MIT License
15 stars 33 forks source link

Added Responsive Navbar #49

Open sakshii00 opened 1 week ago

sakshii00 commented 1 week ago

closes #7

I added a responsive navbar. If you would like any changes, let me know. I worked on the issue alone btw.

Attaching a preview below:-

https://github.com/user-attachments/assets/cf61b82d-4001-45c2-8773-a992372bcbfa

Please note:-

This only has frontend and the routing has not been done. It can be done based on pages or sections that would be implemented in future.

vercel[bot] commented 1 week ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
portfolio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 8, 2024 8:40pm
sakshii00 commented 1 week ago

@kingsmen732 can you please review this too. Just check out the video and let me know if you would like any other changes. I will resolve conflicts and add those changes too.

kingsmen732 commented 1 week ago

@kingsmen732 can you please review this too. Just check out the video and let me know if you would like any other changes. I will resolve conflicts and add those changes too.

i am not having any issues on this but the problem i face in this is the design is not consistent to what we are looking forward to as this one is a basic portfolio and not a minimal one which can be altered for any user in less time

sakshii00 commented 1 week ago

I can add the tabs based on what is needed and I only added the ones that are generic right now. If you have any other preferences, you can let me know. The tabs can also be made dynamic by adding from an array or data file for the tabs.

kingsmen732 commented 1 week ago

we can take your view on what can be based on the current version from the main branch , kindly look through it once and start a discussion in this repo so we can be on the same page about this issue

sakshii00 commented 1 week ago

The navbar will be helpful in navigating to the pages which will be further added in the portfolio.. if the navbar wasn't needed, why did you approve the issue :/ Also if there is no problem with the PR, can you add hacktober-accepted label to it so that it is counted towards hacktober? The PR doesn't need to be merged for that. I would appreciate that since I spent time on making this and ensured it was working fine. @kingsmen732

kingsmen732 commented 1 week ago

https://github.com/kingsmen732/portfolio/issues/59 can we look into having a minimal nav bar based on this feature update from issue 59 mentioned in the above link

sakshii00 commented 1 week ago

Could you please tell me how you want it to be implemented since minimal nav bar seems vague.

Do you want me to add education section in navbar, that goes to section or-?

Please elaborate.

@kingsmen732