search

kingstarter / laravel-saml

A laravel 5.4 / 5.5 SAML plugin that transforms laravel into an IDP.
MIT License
55 stars 29 forks source link

Encode assertion url command #5

Closed neilherbertuk closed 6 years ago

neilherbertuk commented 6 years ago

Removed createBase64AssertionUrl.php and created a new console command to encode assertion urls

   $ php artisan laravel-saml:encodeurl https://sp.webapp.com/saml/login
   --
   URL Given: https://sp.webapp.com/saml/login
   Encoded AssertionURL:aHR0cHM6Ly9zcC53ZWJhcHAuY29tL3NhbWwvbG9naW4=

Updated README.md and comments within config to detail new method of generating base_64 encoded assertion urls

steve-ks commented 6 years ago

Great thing ! I should have also thought about creating an artisan command. Propably I was lazy...

steve-ks commented 6 years ago

I just had the idea that making this even more adorable by directly adding the encoded URL to the saml config file as a new entry, adding maybe also some flags for also including a destination and an issuer. The config:cache should be rebuild anyways afterward, might also be a direct step.

I might check this out next week, as I have hardly time left this week.

neilherbertuk commented 6 years ago

I need to figure out how best to create a PR for this, I might have to re-fork your master branch. Take a look at my fork, I've added configurable attribute assertions allowing each SP to have it's own config for what user model attributes can be sent to the SP along with a few other config options per sp.

steve-ks commented 6 years ago

Sounds all great. Did you do a pull request or do you want to keep this separate in your fork with the configurable SP options ?

Anyhow, don't stress yourself with autoloading new SP assertion URLs if you don't have time. I could do it next week.

chosten commented 6 years ago

Any plan to integrate the configurable attribute assertions from the fork ? It is a must have, the hardcoded name and email wont work for everyone.

neilherbertuk commented 6 years ago

@SquareBeard It's on my to do list. I messed up the fork with merges so do plan on re-forking and reapplying my changes to make it easier to merge in as a PR to the original.