search

kiniry / Mobius

4 stars 8 forks source link

[ escjava-Bugs-582 ] pure equals() in escjava/sortedProver/Lifter classes call non-pure hashCode #140

Open atiti opened 11 years ago

atiti commented 11 years ago

{{{

!html

Reply to: noreply@sort.ucd.ie }}} {{{ Bugs item #582, was opened at 2007-06-27 11:55 You can respond by visiting: http://sort.ucd.ie/tracker/?func=detail&atid=441&aid=582&group_id=97

Category: Prover Interface Group: None Status: Open Resolution: None Priority: 3 Submitted By: Patrice Chalin (chalin) Assigned to: Joseph Kiniry (jkiniry) Summary: pure equals() in escjava/sortedProver/Lifter classes call non-pure hashCode

Initial Comment: Object.equals is declared pure. Object.hashCode is not pure. Hence implementations of equal cannot call hashCode, but this is what is done in two classes contained in Lifter.java.

Comment By: Patrice Chalin (chalin) Date: 2007-06-27 12:29

Message: A fix has been committed. make test pass. I am leaving this ticket Open, pending a code review by you and/or the custodian of the Lifer.java file.

Comment By: Patrice Chalin (chalin) Date: 2007-06-27 11:59

Message: Looking at the implementations of the two equals() methods in question, it seems that calls to equals() for appropriate subfields will be equally valid. I will try this out and commit if no tests are broken.

[Note that the problem reported in this bug was found while working on bug #581.]

You can respond by visiting: http://sort.ucd.ie/tracker/?func=detail&atid=441&aid=582&group_id=97 }}}

atiti commented 11 years ago

From: (GH: None) Date: Sat Dec 15 17:08:02 2007

added mailto line

This message has 0 attachment(s)

atiti commented 11 years ago

From: None (GH: None) Date: Tue Apr 27 14:34:16 2010

Milestone ESCJava2 2.0.9 release deleted

atiti commented 11 years ago

From: (GH: None) Date: Sat Dec 15 17:13:43 2007

added mailto line

This message has 0 attachment(s)

atiti commented 11 years ago

From: dcochran (GH: dcochran) Date: Fri Jan 11 13:07:47 2008

Duplicate of #243

atiti commented 11 years ago

From: (GH: None) Date: Sat Dec 15 17:17:57 2007

added mailto line

This message has 0 attachment(s)

atiti commented 11 years ago

From: kiniry (GH: kiniry) Date: Wed Oct 21 12:28:58 2009

Duplicate of #146.