search

kinjalagarwal1810 / pe

0 stars 0 forks source link

Incorrect error message for relate command #8

Open kinjalagarwal1810 opened 6 months ago

kinjalagarwal1810 commented 6 months ago

image.png

Expected: No person with that index error message

Actual: Ids should only be any integer value larger than 0

nus-se-bot commented 6 months ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Incorrect error message for unrelate command

image.png

Expected: No person with that index error message

Actual: Ids should only be any integer value larger than 0

[original: nus-cs2103-AY2324S2/pe-interim#4967] [original labels: type.FunctionalityBug severity.Low]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

image.png

This is actually caused by integer overflow, but doesn't cause any harm as stated above. However, we agree that integer overflow can be a case that can be considered in the future.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: The 2 commands are different, one is relate and the other is unrelate. Fixing one issue will not automatically fix the other.

## :question: Issue response Team chose [`response.NotInScope`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]