kinkofer / FightClub5eXML

Creating XML files of all D&D sources compatible with Fight Club 5e and Game Master 5e apps for iOS and Android.
MIT License
706 stars 395 forks source link

Some Classes have duplicate spell lists #111

Open SaltyEggs opened 3 years ago

SaltyEggs commented 3 years ago

I've noticed this problem for Artificer and Druid (Land) so far, where the spell is listed twice in their spell lists, and is added to the character sheet twice when picked. 20201126_223403 20201126_223349

alexthake commented 3 years ago

I'm getting a similar issue, it may be because Tasha's reprints a lot of the classes and content, so it may be duplicating and adding both instances of the classes spells into the same directory

mattszcz commented 3 years ago

Only spells from XGE aren't duplicates 🤔

GarnetSan commented 3 years ago

I'm seeing this issue popping up for several people, and I think I've found where the problem lies, at least for the Artificer(I'm using the CoreRulebooksAndSupplements.xml, personally, but probably happens to the Complete.xml file as well).

Whoever made the Collections files added the artificer spell list from both ERLW and Tasha's, meaning that two spell lists are getting added to each spell. Removing the following lines should prevent it from adding the spell twice:

<doc href="../FightClub5eXML/Sources/EberronRisingFromTheLastWar/spells-phb+erlw.xml" /> <doc href="../FightClub5eXML/Sources/EberronRisingFromTheLastWar/spells-xge+erlw.xml" />