search

kinkofer / FightClub5eXML

Creating XML files of all D&D sources compatible with Fight Club 5e and Game Master 5e apps for iOS and Android.
MIT License
702 stars 392 forks source link

magic equipment labeled nonmagical #150

Open Catkingman opened 3 years ago

Catkingman commented 3 years ago

All magic weapons and armor are not labeled as such in the complete compendium, leading all of them to be listed as nonmagical.

francoisbeaulieu commented 3 years ago

Yes, all magic items appear to be missing the <magic>1</magic> tag. They're also missing details about rarity, atunement and often, bonuses. (Ex: +1 Leather Armor performs the same as regular Leather Armor because it's missing the <modifier category="bonus">ac +1</modifier>)

ebullient commented 3 years ago

The magic flag is there some of the time, but it has the value of 1, where Fight Club exports the value YES, not sure if that makes a difference. I did notice that some just have major, and some have rarity. I do agree that most dropped attunement. I have a thought for how to get that back, but it's a bit wild.