search

kinkofer / FightClub5eXML

Creating XML files of all D&D sources compatible with Fight Club 5e and Game Master 5e apps for iOS and Android.
MIT License
706 stars 395 forks source link

Added a simple build-script to the root folder. #182

Closed vidalvanbergen closed 2 years ago

vidalvanbergen commented 2 years ago

Could maybe use an explanation in the readme, but this creates Fight Club importable files in a 'Compendiums' folder.

esabol commented 2 years ago

@vidalvanbergen: I think you're missing a newline at the end of line 2 of build-collections.sh? Might want to add that.

vidalvanbergen commented 2 years ago

I'm not sure why GitHub asks for a new line at the end of file, but i've added it.

esabol commented 2 years ago

I'm not sure why GitHub asks for a new line at the end of file, but i've added it.

GitHub didn't. I did. As for why, POSIX says so. Plenty of additional discussion here: https://stackoverflow.com/questions/729692/why-should-text-files-end-with-a-newline

vidalvanbergen commented 2 years ago

Ah I see, interesting information. Thanks.

zcdziura commented 2 years ago

@kinkofer Will you take a look at this PR and merge if you think that things look OK?