kinnay
commented
1 year ago Hi,
Thanks for your efforts.
The .py files are automatically generated by generate_protocols.py. Could you update the .proto file instead and then run generate_protocols.py?
Otherwise, your changes will be overwritten the next time someone runs generate_protocols.py. This will also automatically update the docs.
Also, there is a dedicated type for principal ids (pids). Please change the type of the principal id fields from u32 to pid.
The reason that there is a dedicated type is that the pid is a u32 on the 3DS and Wii U, but a u64 on the Switch. Even if this protocol isn't used on the Switch, it's best to be explicit and consistent with the type.
If you have any questions, let me know.
This patch set is a rebase of https://github.com/Stary2001/nintendoclients, which was held back at an ancient version due to a lack of effort in maintaining https://github.com/Stary2001/friendbot.
A lot of extras that were added in Stary's fork were already defined upstream, so I did my best in cleaning up the remaining differences.