search

kinnay / NintendoClients

Python package to communicate with Switch, Wii U and 3DS servers
MIT License
558 stars 68 forks source link

Support for Python 3.8 #17

Closed mrexodia closed 5 years ago

mrexodia commented 5 years ago

https://docs.python.org/3/library/hmac.html

Deprecated since version 3.4, will be removed in version 3.8: MD5 as implicit default digest for digestmod is deprecated. The digestmod parameter is now required. Pass it as a keyword argument to avoid awkwardness when you do not have an initial msg.

kinnay commented 5 years ago

Hi,

You made a tiny mistake on line 314 in prudp.py. You're passing hashlib.md5 in the 'msg' parameter instead of 'digestmod', which doesn't work.

If you fix this I can accept your pull request.

mrexodia commented 5 years ago

Good catch! I changed all instances of hmac.new to use a named parameter for digestmod instead, so it cannot happen again.