remove some non-standard utils

kinnay / NintendoClients

Python package to communicate with Switch, Wii U and 3DS servers

MIT License

537 stars 63 forks source link

remove some non-standard utils #43

Closed ioistired closed 4 years ago

ioistired commented 4 years ago

urllib.parse replaces util.urldecode/util.urlencode, and int()/str.isnumeric() replaces util.is_numeric.

kinnay commented 4 years ago

Nice, I wasn't aware of these.

I think we'd want to use str.isdecimal() instead of str.isnumeric() though, because isnumeric also includes "all characters that have the Unicode numeric value property" according to the Python docs.

ioistired commented 4 years ago

Good catch. I knew that isnumeric supported unicode but I didn't know about isdecimal() or that isnumeric() doesn't line up with what int() accepts.