search

kinnison / git-testament

Rust library for creating a commit testament at compile time
BSD 3-Clause "New" or "Revised" License
47 stars 10 forks source link

fix clippy error #26

Closed cemremengu closed 1 year ago

cemremengu commented 1 year ago

self.dir.take().unwrap().into_path() -> let _ = self.dir.take().unwrap().into_path()

kinnison commented 1 year ago

Unless I am mistaken, this will result in DO_NOT_ERASE_TESTS failing to have the desired effect of retaining the intermediate test content. cf. https://docs.rs/tempfile/latest/tempfile/struct.TempDir.html#method.into_path

More usefully I think the line should just be prefixed with let _ =

kinnison commented 1 year ago

Could you please rebase that into one patch?