search

kinnison / marked-data

A YAML representation library which explicitly retains provenance data
MIT License
12 stars 5 forks source link

deps: Use hashlink instead of linked-hash-map #8

Closed GrayJack closed 5 months ago

GrayJack commented 5 months ago

linked-hash-map has been unmaintained for 2 years now and have some issues. And most crates are moving to hashlink which provides the same features.

kinnison commented 5 months ago

Hi,

Thank you for bringing this to my attention - can I ask please what your use/interest in my crate is? Also, changing this dependency will result in a major version bump so you can, I hope, understand if I need to take some time to decide if I want to take this on.

D.

GrayJack commented 5 months ago

Hi!

Thank you for bringing this to my attention - can I ask please what your use/interest in my crate is?

I was the person who introduced this crate to rattler-build. So when I discovered this issue with linked-hash-map crate, I decided to investigate what is the spiritual successor of the crate and I discovered that most crates are migrating to hashlink

Also, changing this dependency will result in a major version bump so you can, I hope, understand if I need to take some time to decide if I want to take this on.

Not a problem to me! 😄

kinnison commented 5 months ago

Thank you for bringing this to my attention - can I ask please what your use/interest in my crate is? I was the person who introduced this crate to rattler-build. So when I discovered this issue with linked-hash-map crate, I decided to investigate what is the spiritual successor of the crate and I discovered that most crates are migrating to hashlink

Aha, thanks, that's helpful for me to know, since rattler-build is one of the main consumers of marked-yaml which I was concerned about.

Also, changing this dependency will result in a major version bump so you can, I hope, understand if I need to take some time to decide if I want to take this on. Not a problem to me! 😄

Coolbeans - I noticed that rattler have already upped to 0.4.0 which surprised me; so I'll definitely give this a go and if all looks well, I'll take it in for a 0.5.0 release soonish. I have a couple of quality-of-life things to do with the serde interface in here first though :D

Thank you again.

kinnison commented 5 months ago

It looks like you've missed all the doctests from your refactor - Could you add a commit to address those?

kinnison commented 5 months ago

Thanks, this'll be in 0.5.0 assuming I get enough time tonight to work through what else I want to do.