Improve node data for inlined PdaValueNodes

[lorisleiva]

Since https://github.com/kinobi-so/kinobi/pull/43, we can now inline PdaNodes directly inside PdaValueNodes, allowing us to defined PDAs that are not defined at the top-level of the program, and therefore, don't need to render helper methods.

PR #42 is in the process of supporting these inlined PDAs when parsing an Anchor IDL.

This issue proposes two further improvements that needs discussing.

• A. Add a default Anchor visitor after #42, that goes through relevant inlined PDAs and extracts them as top-level PdaNodes on the ProgramNode.

• B. Potentially find a way to link an inlined variable Pda seed to an instruction argument to avoid type repetition. Note that this may make it more difficult for us to achieve A as top-level PdaNodes do not have access to the context of instruction arguments.

Cc @kespinola

[Kabie]

https://github.com/kinobi-so/kinobi/blob/ac5bc75156b01855f92f0ed6366cd6c14044fddc/packages/visitors-core/src/identityVisitor.ts#L516-L522

Hi, I tried to inline a PdaNode but this assert in line 520 still blocks it.

[lorisleiva]

Thanks for raising this @Kabie, I've fixed this in https://github.com/kinobi-so/kinobi/pull/94. I'll release a new patch soon.