bug: terminal doesn't respect End or Delete

0x70b1a5 commented 3 months ago

Describe the bug End doesn't move your cursor, and Delete works like Backspace.

To Reproduce Steps to reproduce the behavior:

enter some text
arrow key left some
hit Delete, notice Backspace
hit End, notice no cursor move Expected behavior
normal function of said keys

Desktop (please complete the following information):

            .-/+oossssoo+/-.               mogged@mcdonalds 
        `:+ssssssssssssssssss+:`           -------------- 
      -+ssssssssssssssssssyyssss+-         OS: Ubuntu 24.04 LTS x86_64 
    .ossssssssssssssssssdMMMNysssso.       Kernel: 6.8.0-36-generic 
   /ssssssssssshdmmNNmmyNMMMMhssssss/      Uptime: 4 hours, 21 mins 
  +ssssssssshmydMMMMMMMNddddyssssssss+     Packages: 2536 (dpkg), 46 (nix-user), 12 (flatpak), 30 (snap) 
 /sssssssshNMMMyhhyyyyhmNMMMNhssssssss/    Shell: bash 5.2.21 
.ssssssssdMMMNhsssssssssshNMMMdssssssss.   Resolution: 1440x2560, 2560x1440 
+sssshhhyNMMNyssssssssssssyNMMMysssssss+   DE: GNOME 46.0 
ossyNMMMNyMMhsssssssssssssshmmmhssssssso   WM: Mutter 
ossyNMMMNyMMhsssssssssssssshmmmhssssssso   WM Theme: Adwaita 
+sssshhhyNMMNyssssssssssssyNMMMysssssss+   Theme: Yaru-blue-dark [GTK2/3] 
.ssssssssdMMMNhsssssssssshNMMMdssssssss.   Icons: Yaru-blue-dark [GTK2/3] 
 /sssssssshNMMMyhhyyyyhdNMMMNhssssssss/    Terminal: gnome-terminal 
  +sssssssssdmydMMMMMMMMddddyssssssss+     CPU: 13th Gen Intel i9-13900K (32) @ 5.500GHz 
   /ssssssssssshdmNNNNmyNMMMMhssssss/      GPU: NVIDIA GeForce RTX 3080 Ti 
    .ossssssssssssssssssdMMMNysssso.       Memory: 10256MiB / 64037MiB 
      -+sssssssssssssssssyyyssss+-
        `:+ssssssssssssssssss+:`                                   
            .-/+oossssoo+/-.

dr-frmr commented 3 months ago

A previous issue specifically requested we treat "Delete" and "Backspace" in the same way. I don't care, as I only have a backspace key on my keyboard. I can definitely add proper behavior for "End".

0x70b1a5 commented 3 months ago

Do you mean #361 ? I don't think that was what that issue requested. Reading through it, Lyn seems to be asking for normal Delete functionality, not that Delete be treated like Backspace, but I could be wrong there - either way, by the principle of least astonishment, the terminal should definitely have the normal Delete behavior.

dr-frmr commented 3 months ago

What is the delete key supposed to do vs. the backspace key? Sorry for being ignorant, I have always treated them as equivalent: delete the character to the right of the cursor.

0x70b1a5 commented 3 months ago

Oh my bad, I'm also just remembering now that Macs have their Backspace keys labelled as "Delete".

Backspace deletes the character to the left of the cursor.
Delete deletes the character to the right of the cursor (in a terminal, this would be the character highlighted by the cursor). On my 2017 mac, one can induce this behavior by pressing the Fn+"delete" (actually Backspace) keys.

dr-frmr commented 3 months ago

Huh ok. I can do that, sure

dr-frmr commented 2 months ago

fixed in #443 !

kinode-dao / kinode

bug: terminal doesn't respect End or Delete #431