search

kinode-dao / kinode

Kinode OS runtime
https://kinode.org
Apache License 2.0
35 stars 13 forks source link

terminal: m caps #596

Open nick1udwig opened 1 week ago

nick1udwig commented 1 week ago

Problem

m doesn't send caps with messages, #579 #581

Solution

Attach caps that were issued by a given process and that are held by terminal to m Requests.

Testing

m our@contacts:contacts:sys "GetNames"

Docs Update

None

Notes

This still doesn't resolve #579 & #581 completely. The issue that remains is that there is no way for a process to pass a userspace cap to terminal. We either need to:

  1. Change manifest field grant_capabilities to allow non-messaging caps to be granted,
  2. Add a terminal:terminal:sys api that allows processes to give it capabilities.
dr-frmr commented 5 days ago

Change manifest field grant_capabilities to allow non-messaging caps to be granted

it's an oversight that this doesn't currently work -- i'm surprised this code does not allow it: https://github.com/kinode-dao/kinode/blob/28664d7c27261dfd74127a85a020fd5452faa75e/kinode/packages/app-store/app-store/src/utils.rs#L342-L391