Craft 4 compatibility? - Githubissues

kinoli / groupie

Assign users to specific user groups upon registration. Especially useful for front-end signup forms.

Other

3 stars 0 forks source link

Craft 4 compatibility? #13

Open karljennings opened 2 years ago

karljennings commented 2 years ago

Just wondering if there is any plan to update for Craft 4?

kinoli commented 2 years ago

Not at the present.

chadcrowell commented 2 years ago

@kinoli Do you mind if I fork and release for C4 then?

kinoli commented 2 years ago

sure thing.

chadcrowell commented 2 years ago

Just released Groupie for Craft 4. Thanks Jesse for this great little plugin.

chadcrowell commented 2 years ago

Btw Jessie do you want to continue to maintain the C3 version? If not, assign this repo over to me and I'll maintain both the C3 and C4 versions. Otherwise I'll need to rename my C4 version so it can go into the plugin store.

kinoli commented 2 years ago

I'm fine maintaining the C3 version.

chadcrowell commented 2 years ago

Hey again, plugin got rejected by P&T - sounds like the options (straight from Brandon) are:

You give ownership of the current plugin to me, and I release the C4 updates in the current repo.
I rename the C4 version of Groupie to something completely different and release it. There can't be your Groupie for C3 and mine for C4, that doesn't work. If I rename it and release it, they will mark your Groupie as abandoned and list mine as the recommended replacement for C4. If it is marked as abandoned, you won't be able to accept license fees/renewals for your version any longer.
I can just use my C4 version for my own needs and not have it in the plugin store.

I'm really fine with any of these. My intent was not to make any additional work for you or take away your revenue from this plugin. I feel like the cleanest way to go is #3, I can just install it for my own needs via composer and move on with life.

kinoli commented 2 years ago

Why dont you just add a pull request for your changes into this repo and it will update in Craft?

chadcrowell commented 2 years ago

Certainly an option, but I hadn't gone that direction because you seemed to indicate you didn't want to deal with the C4 version. Works for me though.

kinoli commented 2 years ago

No, it's fine as long as it doesn't break C3 version.

robinbeatty commented 2 years ago

I'm someone who's champing at the bit with my wallet open for a C4 version... any options available yet?

kinoli commented 2 years ago

Ok, I'll work on an updated version so it works in Craft 3 and 4. Stay tuned.

chadcrowell commented 2 years ago

I'll setup my pull request today Jesse, hang tight. Save you some time.

chadcrowell commented 2 years ago

Hi Jessie - do you mind creating a tagged release for the C 3/4 version so packages will update and it will be available in C4?

chadcrowell commented 1 year ago

Hi Jessie - do you mind creating a tagged release for the Craft 3/4 version so packagist will update and it will be available in C4? This has just been sitting here since you merged the pull request. Meanwhile, Craft plugin store has no idea it exists for C4.

jcdarwin commented 1 year ago

If you need to install this package but it hasn't been tagged, you can use an inline alias:

php composer require "kinoli/groupie:dev-master#e7abdf81a185fa614b9d6385dc587fd994f111f3 as 2.0.0"

iamkeir commented 1 year ago

+1 for this being C4 compatible

iamkeir commented 1 year ago

Any update here?

ThomasDeMarez commented 1 year ago

Seems like Packagist is not synced with the new 2.0.0 release, could you update this on the Packagist side?

In the meantime we are using an inline alias as suggested by @jcdarwin.