Suggestion for v2.0 (ES6+ version)

[lamuertepeluda]

Hey there,

I was trying to use your library, but I had some difficult importing it using my module bundler (webpack).

So after some time I gave up and rewrote it entirely using a more modern syntax. I wanted to share this with you, since I tried to make it backward compatible (although compatibility is 100% untested) and it seems to work. I used axios, a promise based ajax library which works well on both browser and node. So you could drop a bunch of superseeded dependencies.

I also added the HTTPS endpoint as baseURL since it's more suited for modern websites.

See the code and how it works on StackBlitz: https://stackblitz.com/edit/js-hqzhep?file=Geonames.js

If you think ES5 compatibility is important, we can make a webpack config file for transpiling it.

Feel free to use this code to make a new version of this library if you wish.

[kinotto]

Hi @lamuertepeluda, you are absolutely correct, i was using the request library to make ajax calls on the browser, that is exclusively a node library, that is why webpack was raising an error at build time. today i updated the library, v2.0, new compact and elegant ES6+ syntax integrated with webpack and babel to allow transpiling for both client and server, the code has been tested in both environments and seems to work fine (check out the readme :) ) I followed your advice and used axios as well, with the secure endpoint rather then the normal one.

thank you very much for the effort you made in providing your code, hope you will be able to include the library now :) Best

[lamuertepeluda]

Hi @kinotto,

I'm glad you integrated my suggestions for v2.0! 😃

I'd like to suggest you the following steps (will fork and make PRs as soon as I have time if you agree) in order to improve this library further:

• keep the class syntax (support is nowadays broad on both browser and node, but with Babel you may transpile it to ES5 without worrying
• update the examples adding the async/await version (same as above for browser and node
• add source maps to dist (useful when debugging)
• (optional, but great) either refactor to Typescript. or add ts definitions.
• (optional, but with minor priority) release the .mjs (ES6 module) for it will be used in both node and browser

what do you think about it?

[kinotto]

@lamuertepeluda

• ok
• ok
• i removed the source maps on purpose since they were increasing significantly the bundle size, anyway you have a point, they could be useful at runtime to debug the application, even if the library is quite small, and there is not too much to inspect. anyway you can give it a try, maybe if you find some way to avoid a huge increment on the compiled code (maybe other webpack plugins ??)
• ok, sounds good
• i don't see it necessary to be honest, i'd leave this for the future :)

i'll be more than happy to accept your PR and add you as a collaborator to the project, just please run the unit tests once finished.

Actually would be nice to improve the coverage of the tests, now they cover only the 70% of the code but maybe you can improve it (not strictly necessary, but if you find time would be great)

thanks again 👍