search

kinotto / geonames.js

Nodejs and Browser client for Geonames.org REST API :earth_africa:
http://www.geonames.org/export/client-libraries.html
MIT License
88 stars 17 forks source link

Add async/await to example #4

Closed lamuertepeluda closed 6 years ago

lamuertepeluda commented 6 years ago

Hi @kinotto ,

I started by the easiest: adding an async/await example to the README. I also added myself to the contributors list (just in case you merge this PR).

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 70.588% when pulling ec9474e8b292ce72552b6797aba59c1d496f5f7e on lamuertepeluda:master into 9fc94a5f5970cf34c7924abd4dff9650c6ee6ec1 on kinotto:master.

kinotto commented 6 years ago

@lamuertepeluda , ok great. i'll leave you time to implement the rest. For future PR's create a branch from master with a name that reflects the name of the functionality you're adding.

i'll take a look at the PR's over the weekend, 👍 thanks

lamuertepeluda commented 6 years ago

maybe I should close this in favor of #5? I think I messed it up by pushing to my master branch, but I was using my fork in a project...

kinotto commented 6 years ago

yes, if the other PR includes all the changes, absolutely :)

lamuertepeluda commented 6 years ago

ok done :)