search

kinsi55 / BeatSaber_BetterSongList

Adds Various improvements to the Basegame song list like Filters, a persisted state and much more
MIT License
42 stars 12 forks source link

Show user approxiamte number of crouches in a map #25

Open Ereiarrus opened 1 year ago

Ereiarrus commented 1 year ago

Instead of just showing the user that a map contains crouches, we now also show them the approximate (upper bound) number of crouches the map contains.

Also, fixed backwards compatibility with SongDetails mod - on BS 1.28, 'starsBeatLeader' field doesn't exist in the song difficulty class - so we use reflections.

kinsi55 commented 1 year ago

Hm, I disagree with this change, specifically for the reason of it only being an approximate number.

If I was to add this, it would have to be built on top of a more robust crouch-counting-logic as otherwise, this doesnt really add anything to the user experience.

Ereiarrus commented 1 year ago

The counting logic uses the same logic that is used to detemine if a map has any squats in the first place.

From my experience of playing beat saber maps, if they aren't noodle maps or more than 4 lane maps, it's 100% accurate; otherwise, it's an overestimate.

Having a robust squat counting logic is difficult when mods allow mappers to place walls however they please. The only imrpovement I can see being made to this is for >4 lane maps, but i don't know how to accurately determine how many lanes a map has.

Besides, it doesn't remove any functionality - if the yellow number shows up, it means the map has squats; it now shows even more information in the form of a number of squats counter - that you can choose to ignore.