Closed nicoco007 closed 1 year ago
Based off a 1 minute decompiler check, am I assuming correctly that the fix would also work properly if you only set it to false if addedToHierarchy
is true?
Maybe, but since the issue is related to ClearChildViewControllers
, the else if (_loading)
might also come into play at some point. ClearChildViewControllers
is eventually called by all code paths so I thought it'd be simpler to just set it to false
no matter what.
I see, well its more or less essentially a basegame issue (Since I use basegame logic to set the start state) so please report to devs 👍
_hideDetailViewController
doesn't get reset properly inLevelCollectionNavigationController.DidActivate
and causes a race condition that doesn't dismiss view controllers properly on the level end screen if:This causes
ClearChildViewControllers
to be called too early and eventuallyHMUI.Screen.SetRootViewController
gets called twice in a row for the same screen, which in turn causesTransitionCoroutine
to be cancelled so the previous view controller (i.e. the leaderboard) is never dismissed/disabled.Basically, this is a fix for this issue: