Fix random not working with all songs

kinsi55 / BeatSaber_BetterSongList

Adds Various improvements to the Basegame song list like Filters, a persisted state and much more

MIT License

43 stars 11 forks source link

Fix random not working with all songs #34

Open rube200 opened 7 months ago

rube200 commented 7 months ago

I was trying to randomize musics with all songs collection, but it wasnt working. After digging and debugging the plugin code, i found out the problem is the harmony patch. In the original LevelCollectionTableView.SetData method the parameter previewBeatmapLevels is IReadOnlyList and not an array. When the player sets collection to All songs the games passes an IReadOnlyCollection does not working. If you debug it as an array the collection will have a count of 0.

kinsi55 commented 7 months ago

Hi, thank you. I suppose this is an issue in the latest version? I never noticed something this before

rube200 commented 7 months ago

My currently installed version is the latest (1.34.2). When i was debugging lastInMapList and lastOutMapList were empty when selecting all soungs.