search

kinsi55 / BeatSaber_BetterSongList

Adds Various improvements to the Basegame song list like Filters, a persisted state and much more
MIT License
42 stars 12 forks source link

Fix for Beat Saber 1.36.0 #36

Closed qe201020335 closed 5 months ago

qe201020335 commented 5 months ago

I have not checked the compatibility with 1.36.2

kinsi55 commented 5 months ago

Generally compatible with 1.36.2 by the looks, however its blocked by a BSML issue

qe201020335 commented 5 months ago

Forgot to mention the star icon is now a heart for some reason. 1.36.0 and 1.36.2 image I will try to find the star icon.

kinsi55 commented 5 months ago

Its missing crouch wall detection anways which I'll have to look into also

qe201020335 commented 5 months ago

Hmmm I thought I have fixed the crouch wall detection.

kinsi55 commented 5 months ago

Oh my bad I thought it was gone, I didnt realize you moved the code. I'll have to take a look

qe201020335 commented 5 months ago

The heart and star icons have the same name. I'm not sure how to distinguish them from code. I think we can use the stroke one?

image image image

qe201020335 commented 5 months ago

image

Meivyn commented 5 months ago

The heart and star icons have the same name. I'm not sure how to distinguish them from code. I think we can use the stroke one?

I did use Resources.FindObjectsOfTypeAll<Sprite>().Last(s => s.name == "FavoritesIcon") but that is not guaranteed to always work. The stroke icon looks a bit weird to me, I guess it's up to Kinsi. There's not much else we can do, I don't think the game uses that sprite anymore.

kinsi55 commented 5 months ago

I'm not a fan of the crouchwall detection being so complex now / requiring a transpiler. That just asks to break every other update. Why did you do it this way?

Edit: I just read the sourcecode, to be fair, crouchwall detection was something that I always added "because I can" for "free". Better Song List, and all my plugins, are about being lightweight - And explicitly loading the map just to realize crouchwall detection... I'm not a fan of that. I'll just cut the feature entirely

kinsi55 commented 5 months ago

LGTM thanks a bunch!