kinsi55 / CS_BeatSaber_Camera2

Adds a lot of options / tools for creating more advanced desktop viewing experiences with multiple camera angles and much more in Beat Saber
MIT License
122 stars 17 forks source link

Occasional game crashes when trying to view a replay #2

Closed kinsi55 closed 3 years ago

kinsi55 commented 3 years ago

Occasionally when trying to view a replay the game will hard cash. The Stacktrace points to Scoresaber but it might be related to me disabling the replay camera?

Stack:

========== OUTPUTTING STACK TRACE ==================

0x00007FFBC298B12B (UnityPlayer) UnityMain
0x00007FFBC298981D (UnityPlayer) UnityMain
0x00007FFBC292C4A4 (UnityPlayer) UnityMain
0x00007FFBC2A31EEE (UnityPlayer) UnityMain
0x0000020E49C5793A (Mono JIT Code) (wrapper managed-to-native) UnityEngine.Resources:FindObjectsOfTypeAll (System.Type)
0x0000020E49C57823 (Mono JIT Code) UnityEngine.Resources:FindObjectsOfTypeAll<T_REF> ()
0x0000020FE150BC03 (Mono JIT Code) ScoreSaber.ReplayPlayer/#=zfWmBBe7Up5pU8$MOOkyj_aI=/#=zeZWG$G0Vatxi6L4chHSiveM=:MoveNext ()
0x0000020D92C3E222 (Mono JIT Code) System.Runtime.CompilerServices.AsyncMethodBuilderCore/MoveNextRunner:InvokeMoveNext (object)
0x0000020D90A11336 (Mono JIT Code) System.Threading.ExecutionContext:RunInternal (System.Threading.ExecutionContext,System.Threading.ContextCallback,object,bool)
0x0000020D90A10C0B (Mono JIT Code) System.Threading.ExecutionContext:Run (System.Threading.ExecutionContext,System.Threading.ContextCallback,object,bool)
0x0000020D92C3E0DB (Mono JIT Code) System.Runtime.CompilerServices.AsyncMethodBuilderCore/MoveNextRunner:Run ()
0x0000020D92C3D6A5 (Mono JIT Code) System.Threading.Tasks.AwaitTaskContinuation:RunOrScheduleAction (System.Action,bool,System.Threading.Tasks.Task&)
0x0000020D91677BAB (Mono JIT Code) System.Threading.Tasks.Task:FinishContinuations ()
0x0000020D916769B3 (Mono JIT Code) System.Threading.Tasks.Task:FinishStageThree ()
0x0000020D93170CEB (Mono JIT Code) System.Threading.Tasks.Task`1<System.Threading.Tasks.VoidTaskResult>:TrySetResult (System.Threading.Tasks.VoidTaskResult)
0x0000020D9317148B (Mono JIT Code) System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1<System.Threading.Tasks.VoidTaskResult>:SetResult (System.Threading.Tasks.VoidTaskResult)
0x0000020D93171383 (Mono JIT Code) System.Runtime.CompilerServices.AsyncTaskMethodBuilder`1<System.Threading.Tasks.VoidTaskResult>:SetResult (System.Threading.Tasks.Task`1<System.Threading.Tasks.VoidTaskResult>)
0x0000020D9317124B (Mono JIT Code) System.Runtime.CompilerServices.AsyncTaskMethodBuilder:SetResult ()
0x0000020FE150D88B (Mono JIT Code) ScoreSaber.ReplayPlayer/#=zEfVaR1zpCvBvmrRC7g==:MoveNext ()
0x0000020D92C3E222 (Mono JIT Code) System.Runtime.CompilerServices.AsyncMethodBuilderCore/MoveNextRunner:InvokeMoveNext (object)
0x0000020D90A11336 (Mono JIT Code) System.Threading.ExecutionContext:RunInternal (System.Threading.ExecutionContext,System.Threading.ContextCallback,object,bool)
0x0000020D90A10C0B (Mono JIT Code) System.Threading.ExecutionContext:Run (System.Threading.ExecutionContext,System.Threading.ContextCallback,object,bool)
0x0000020D92C3E0DB (Mono JIT Code) System.Runtime.CompilerServices.AsyncMethodBuilderCore/MoveNextRunner:Run ()
kinsi55 commented 3 years ago

Seems to have been fixed by global FPS limit lmao (https://github.com/kinsi55/CS_BeatSaber_Camera2/commit/8870da54be7242b624e93709d950efb09a8fd6ac)