search

kinsi55 / CS_BeatSaber_Camera2

Adds a lot of options / tools for creating more advanced desktop viewing experiences with multiple camera angles and much more in Beat Saber
MIT License
118 stars 13 forks source link

Camera showing in FPFC mode even when no scenes have FPFC + Issue with room rotation #72

Closed tophattwaffle closed 2 years ago

tophattwaffle commented 2 years ago

Running 1.22. Have 3 cameras as you'll see in the config. The "FPS" camera is my main camera and has FPFC scene disabled, but it shows anyways when in FPFC mode.

This camera showing isn't exactly a massive issue on it's own - but with 1.22 there seems to be something strange with room rotation enabled.

I've scaled down the "FPS" camera in this screenshot, so the main view is from base game. The Camera2 FPS view is rotation 90 degrees. image

Setting room rotation back to 0 has my FPS camera working as expected. image

My config file: Camera2.zip

kinsi55 commented 2 years ago

The Roomadjust issue is something I've already fixed, just didnt release yet.

As for the camera being there that doesnt exist - Thats the basegame FPFC camera which exists behind Camera2 cameras when FPFC is active. You can see its not a Cam2 camera because you cannot resize it

tophattwaffle commented 2 years ago

Glad the room adjust thing will have a fix coming. I'll wait patiently for it. :)

As for the other camera, I understand that the base game camera is always just covered up by the mod. However shouldn't my camera named "fps" not exist when I'm in FPFC mode since it's not enabled under scenes.

In any case, since a fix is coming feel free to resolve this issue.

As always, you rock.

On Fri, May 13, 2022, 05:50 Kinsi @.***> wrote:

The Roomadjust issue is something I've already fixed, just didnt release yet.

As for the camera being there that doesnt exist - Thats the basegame FPFC camera which exists behind Camera2 cameras when FPFC is active. You can see its not a Cam2 camera because you cannot resize it

— Reply to this email directly, view it on GitHub https://github.com/kinsi55/CS_BeatSaber_Camera2/issues/72#issuecomment-1125922149, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABTV23IB3ECNKD6PKB5NG7DVJYXWZANCNFSM5V2QDQUA . You are receiving this because you authored the thread.Message ID: @.***>

kinsi55 commented 2 years ago

The way the Scene system works is there is always a camera active. Scenes have a hierarchy to them, and if FPFC happens to be empty, it will use the next best scene, which, when you are in the Menu, is Menu, where your fps cam resides

For the hierarchies see: https://github.com/kinsi55/CS_BeatSaber_Camera2/wiki/Scenes