kinsidar / Association-Contacts

MIT License
1 stars 1 forks source link

Refactoring and upsizing the database #19

Open peterennisrda opened 6 years ago

peterennisrda commented 6 years ago
  1. Use id for all tables (lowercase)
  2. FKs fields will become e.g. tblContactsId
  3. Use Camel case for field names, e.g. firstName
  4. No underscores in object names, e.g. lstContacts and not lst_Contacts
  5. VBA code will use 3 letter notation e.g. strFluffy and not sFluffy when values are passed into procedures.
  6. Single letter type identifiers e.g. sString, iFluffyInteger, bBobBoolean are allowed only when they are local to a procedure.
  7. Explicitly define Private or Public in all cases
  8. One empty line between procs
  9. Indents of 4 spaces and no empty spaces at the end of a line
  10. Blank lines should not have spaces or tabs

Update the developer style guide for the standard being adopted.

We can consider tooling or some lint process to enforce this as progress is made.

Recommended process:

Phase 0: A. Document as you go! B. Create bugs/tasks/ issues internally in log file C. Create GitHub tickets if you are stuck using @peterennis D. As much as possible create atomic commits for each fix E. Create incremental zip files that contain version controlled work

Phase 1: A. Copy the db B. Remove all table relations C. Fix id and field names D. Reconnect table relations E. Verify index names and fix as needed F. Review and verify db design

Phase 2: A. Fix all queries to match new names using SQL view B. Fix all form identifiers and references C. Fix all Code Behind Form (CBF) details for new names D. Fix all of your modules code to match names and standards

Phase 3: A. Test and Fix bugs B. Run access to SQL conversion for data C. Connect front end to SQL and test D. Run access to Azure SQL conversion for data E. Connect front end to Azure SQL and test

kinsidar commented 6 years ago

@peterennis

Just wanted clarification with few of the points:

  1. FKs fields will become e.g. tblContactsId
    • What are FK fields?

Indents of 4 spaces and no empty spaces at the end of a line

peterennisrda commented 6 years ago

FK: Foreign Key Ref: https://en.wikipedia.org/wiki/Foreign_key etc.

Tabs can be used but they will be marked as differences when someone else uses spaces. Spaces before EOL will also show differences, i.e. "commit spam". This becomes annoying to devs in a team environment, hence the rise in linting tools formatting policies. Ref: https://stackoverflow.com/questions/8503559/what-is-linting

It could be managed with the aegit export tool, but is not a priority.

peterennis commented 6 years ago

@kinsidar, Pending PRs fix the above so that we are now on "Phase 3".

xtay573269555 commented 8 months ago

Hello,

We have an exciting opportunity for you! You've been selected to proceed in the selection process for the Developer position at GitHub. Congratulations on your achievement!

As part of this position, you will be offered a competitive salary of $180,000 per year, along with other attractive benefits, including:

* Health insurance coverage

* Retirement savings plan

* Flexible work schedule

* Generous vacation and paid time off

* Professional development opportunities

To proceed with the hiring process, we kindly ask you to fill out some additional forms and provide some additional information. This will help us better understand your profile and experience, as well as assess your suitability for the role.

Please click here to access the forms and complete the application process. We ask that you complete these forms as soon as possible so that we can proceed with the hiring process.

Important: You have 24 hours to complete the application process.

If you have any questions or need further information, please don't hesitate to contact us.

Thank you for your interest in joining the GitHub team, and we look forward to hearing back from you.

Best regards, GitHub Recruitment Team henrybeezhao, @SedemBalfour, @johnnybairstrow, @tanguyantoine, @hldh214, @117503445, @fynxiu, @GinRyan, @ioedeveloper, @xtay573269555, @andresoro, @mingrui, @Zowie, @hoangnt2601, @wrtgj, @kadirsaritas, @qwertyuiop6, @fadeAce, @semoal, @RobotAmiee

This is a phishing and scam message.

tanguyantoine commented 8 months ago

@xtay573269555 tell the truth, you don't want others to apply 🤣

ioedeveloper commented 8 months ago

Scam