search

kint-php / kint

Kint - Advanced PHP dumper
https://kint-php.github.io/kint/
MIT License
2.78k stars 292 forks source link

Kint CSS problem on dark background #213

Closed DRSDavidSoft closed 8 years ago

DRSDavidSoft commented 8 years ago

Let's say I run Kint on a webpage with the following CSS: body { background: #333; text-shadow: 0 1px black;

IMO, Kint should add the following style globally: text-shadow: none;

(Or, add text-shadow: 0 1px white; so it looks better both on dark and bright backgrounds).

Otherwise, it would look like this: image

Also, the .kint footer should have a bright background, if the color is set to be black.

P.S., I asked this a while ago but don't remember the answer, does Kint have a dark theme? Does it support outputting HTML content without adding its CSS, so I can write my own theme for Kint?

jnvsor commented 8 years ago

Also, the .kint footer should have a bright background, if the color is set to be black.

202 "Make kint minitrace more readable" makes kint minitrace less readable... Called it :)

DRSDavidSoft commented 8 years ago

@jnvsor Thanks Also, about themes: please guide me on 1) disabling them 2) choosing from different Kint themes 3) guide to write my own theme

Are any of these in the docs?

jnvsor commented 8 years ago

Not in the docs, and kint master is very rigid with these things, you'll have to edit files inside kint folders to make your own. See Kint::$theme and Kint_Decorators_Rich::init

raveren commented 8 years ago

The information in your screenshot is still readable despite the shadow so it's a very niche and easily ignorable problem. I am closing this issue, but I would accept a readability-focused PR, however, witch would prevent the text-shadow from appearing on Kint elements and the footer text color fixed for once.

Information on how to change themes is available in the main README.