kint-php / kint

Kint - Advanced PHP dumper
https://kint-php.github.io/kint/
MIT License
2.77k stars 291 forks source link

Solarized-dark theme changes body text and background color #405

Closed LoranRendel closed 1 year ago

LoranRendel commented 1 year ago

Solarized-dark theme changes body text and background color making page unreadable for complex design pages.

jnvsor commented 1 year ago

Yeah I suppose the purpose of that was superseded by the rich folder. I'll have to do some other tweaks to the style after removing the body styles but I'll remove that since it's inconsistent with the other themes

jnvsor commented 1 year ago

Fixed in b8b1da8 (5.0.4)

LoranRendel commented 1 year ago

Thanks.

However, .kint-rich uses margin and there will be stripes. image image

It will be better to set box-shadow: 0 0 0 10px #073642 for .kint-rich or remove margin: image image

jnvsor commented 1 year ago

.kint-rich uses margin

This is consistent with all the other themes. If you want to remove the margin (Or change it to padding or something) make your own style changes and put them in your stylesheet or RichRenderer::$pre_render_sources

LoranRendel commented 1 year ago

Already did. Yes, you're right, thanks!